Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileTarget: Fix archiving for ArchiveFileName without a pattern. #1109

Merged
merged 3 commits into from
Dec 25, 2015
Merged

FileTarget: Fix archiving for ArchiveFileName without a pattern. #1109

merged 3 commits into from
Dec 25, 2015

Conversation

bhaeussermann
Copy link
Contributor

Fixes issue #1108

@codecov-io
Copy link

Current coverage is 73.23%

Merging #1109 into master will increase coverage by +0.28% as of 9235a31

@@            master   #1109   diff @@
======================================
  Files          263     263       
  Stmts        14967   14972     +5
  Branches      1633    1637     +4
  Methods          0       0       
======================================
+ Hit          10919   10965    +46
+ Partial        422     421     -1
+ Missed        3626    3586    -40

Review entire Coverage Diff as of 9235a31

Uncovered Suggestions

  1. +0.09% via ...nternal/AspHelper.cs#206...218
  2. +0.09% via ...nternal/AspHelper.cs#188...200
  3. +0.09% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified
304NotModified reviewed Dec 22, 2015
View reviewed changes
src/NLog/Targets/FileTarget.cs
@@ -524,6 +538,23 @@ protected internal string NewLineChars
}
}

private void RefreshFileArchive()
{
var dummyEvent = new LogEventInfo();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have LogEventInfo.CreateNullEvent() for this :)

@304NotModified
Copy link
Member

hey @bhaeussermann, thanks for your contribution again!

I just checked your code in a short time (not done yet), and I have added some code comments. We will review you code more in depth soon.

We are really pleased with your contributions! Nice findings and fixes! Also happy with your good explanation :)
Would you like to join the NLog team? :)

@304NotModified 304NotModified added the bug Bug report / Bug fix label Dec 22, 2015
bhaeussermann
bhaeussermann reviewed Dec 23, 2015
View reviewed changes
tests/NLog.UnitTests/Targets/FileTargetTests.cs
{
logger.Debug("ccc");
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I extended the test to check that the second archive is created.

@bhaeussermann
Copy link
Contributor Author

Would you like to join the NLog team? :)

Sure! :P

@bhaeussermann
FileTarget: Fix archiving for ArchiveFileName without a pattern.
5b31161 
Refactor - use LogEventInfo.CreateNullEvent().
@304NotModified
Copy link
Member

Cool! Check your mail and https://gitter.im/NLog/devs

@304NotModified 304NotModified added this to the 4.3 milestone Dec 25, 2015
304NotModified added a commit that referenced this pull request Dec 25, 2015
@304NotModified
Merge pull request #1109 from bhaeussermann/branch1
5db1eae 
FileTarget: Fix archiving for ArchiveFileName without a pattern.
@304NotModified 304NotModified merged commit 5db1eae into NLog:master Dec 25, 2015
@304NotModified 304NotModified mentioned this pull request Dec 25, 2015
Closed
@304NotModified
Copy link
Member

Thanks! I has been merged!

@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhaeussermann @codecov-io @304NotModified @UgurAldanmaz