FileTarget: Fix continuous archiving bug. #1125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1124
The bug manifested since we were archiving based on the log file's creation time, but it seems to be caused by a strange anomaly with the Windows file system:
When we archive, the log file is moved to the archive file path. However, when the new log file is created, it ends up having the same creation time of the old log file (which is now archived).
Others have observed this behavior, and it turns out is caused by the Windows NT Tunneling capabilities which is meant to facilitate the safe saving mechanism of MS-DOS programs.
The fix is to manually set the creation time of the file when it is created.