Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget: Fix continuous archiving bug. #1125

Merged
merged 4 commits into from
Jan 2, 2016

Conversation

bhaeussermann
Copy link
Contributor

Fixes #1124

The bug manifested since we were archiving based on the log file's creation time, but it seems to be caused by a strange anomaly with the Windows file system:
When we archive, the log file is moved to the archive file path. However, when the new log file is created, it ends up having the same creation time of the old log file (which is now archived).

Others have observed this behavior, and it turns out is caused by the Windows NT Tunneling capabilities which is meant to facilitate the safe saving mechanism of MS-DOS programs.

The fix is to manually set the creation time of the file when it is created.

@codecov-io
Copy link

Current coverage is 73.21%

Merging #1125 into master will increase coverage by +0.03% as of 7208d18

@@            master   #1125   diff @@
======================================
  Files          264     264       
  Stmts        14926   14924     -2
  Branches      1635    1634     -1
  Methods          0       0       
======================================
+ Hit          10923   10927     +4
+ Partial        419     417     -2
+ Missed        3584    3580     -4

Review entire Coverage Diff as of 7208d18


Uncovered Suggestions

  1. +0.10% via ...nternal/AspHelper.cs#206...218
  2. +0.10% via ...nternal/AspHelper.cs#188...200
  3. +0.10% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Copy link
Member

Thanks! Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants