Max message length option for Eventlog target

[UgurAldanmaz]

For #1102

[codecov-io]

Current coverage is 73.36%

Merging #1127 into master will increase coverage by +0.14% as of 29c05d4

@@            master   #1127   diff @@
======================================
  Files          264     264       
  Stmts        14923   14951    +28
  Branches      1633    1637     +4
  Methods          0       0       
======================================
+ Hit          10928   10969    +41
+ Partial        417     416     -1
+ Missed        3578    3566    -12

Review entire Coverage Diff as of 29c05d4

---

Uncovered Suggestions

1. +0.09% via ...nternal/AspHelper.cs#206...218
2. +0.09% via ...nternal/AspHelper.cs#188...200
3. +0.09% via ...nternal/AspHelper.cs#170...182
4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

[304NotModified]

Please no Hungarian names. It's considered bad style.

[304NotModified]

Thanks! Reviewed it, some small things.

Recommended read: http://dontcodetired.com/blog/post/Creating-Inline-Data-Driven-Tests-in-xUnit.aspx

Note: we are still on xunit 1 in this repos

[UgurAldanmaz]

Thanks for review @304NotModified! I will be available to take a look them in detail this evening.

[304NotModified]

👍

[UgurAldanmaz]

I am done! Thanks again.

BTW, I made some comments, but they are not visible because of outdated diff. :)

[304NotModified]

Thanks! But what about the argumentexpection? Is this consists with other targets? (I only see the removal of the unit test)

[304NotModified]

Edit: see your comment now. Will read that first.

[304NotModified]

I think you have a valid point. I will double check other targets for consistency, as I also don't know what is consistent now. :) (and I should have to know it)

[304NotModified]

Oops, forgot to asign myself.

Well I don't like the ArgumentException, but it's consistent, so merge!

Great work! Thanks!

[304NotModified]

@UgurAldanmaz Can you add the new option on the wiki? (please add "Introduced in NLog 4.3")

[UgurAldanmaz]

I added wiki informations.

Thanks a lot @304NotModified!