Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Memory Allocations in LongDateLayoutRenderer #1139

Conversation

epignosisx
Copy link
Contributor

Removes a memory allocation inside StringBuilder when doing number.ToString() we can simply reuse existing method to remove allocation.

@codecov-io
Copy link

Current coverage is 73.33%

Merging #1139 into master will increase coverage by +0.01% as of 9ac9cbc

@@            master   #1139   diff @@
======================================
  Files          264     264       
  Stmts        14944   14944       
  Branches      1636    1636       
  Methods          0       0       
======================================
+ Hit          10958   10959     +1
+ Partial        417     416     -1
  Missed        3569    3569       

Review entire Coverage Diff as of 9ac9cbc


Uncovered Suggestions

  1. +0.09% via ...nternal/AspHelper.cs#206...218
  2. +0.09% via ...nternal/AspHelper.cs#188...200
  3. +0.09% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Copy link
Member

Thanks!

304NotModified added a commit that referenced this pull request Jan 8, 2016
…LayoutRenderer

Reduce Memory Allocations in LongDateLayoutRenderer
@304NotModified 304NotModified merged commit edfce75 into NLog:master Jan 8, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants