-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception when base.InitializeTarget() is not called + inline GetAllLayouts() #1191
Conversation
Current coverage is
|
Whoops! It seems after merging the test now throws |
I think |
Changed to |
Throw exception when base.InitializeTarget() is not called + inline GetAllLayouts()
base.InitializeTarget()
, you can get a nullRefException inTarget.PrecalculateVolatileLayouts
(called inAsyncWrapper/BufferWrapper). The nullref is now fixed, but you still get odd behaviour, so we will check if
base.InitializeTarget()` has been called.