Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internallogger improvements #1259

Merged
merged 3 commits into from
Feb 24, 2016
Merged

Internallogger improvements #1259

merged 3 commits into from
Feb 24, 2016

Conversation

304NotModified
Copy link
Member

  • Log name of AsyncWrapper / BufferingWrapper to InternalLogger.
  • fix count logging of BufferingWrapper
  • improve unit tests

fixes #1251

@codecov-io
Copy link

Current coverage is 74.59%

Merging #1259 into master will decrease coverage by -0.06% as of b07bb14

@@            master   #1259   diff @@
======================================
  Files          267     267       
  Stmts        15407   15407       
  Branches      1615    1615       
  Methods          0       0       
======================================
- Hit          11502   11493     -9
+ Partial        380     379     -1
- Missed        3525    3535    +10

Review entire Coverage Diff as of b07bb14

Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#282...295
  2. +0.09% via ...gingConfiguration.cs#248...261
  3. +0.09% via ...argets/FileTarget.cs#1704...1716
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Feb 24, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Feb 24, 2016
304NotModified added a commit that referenced this pull request Feb 24, 2016
@304NotModified
Merge pull request #1259 from NLog/internallogger-improvements
734b932 
Internallogger improvements
@304NotModified 304NotModified merged commit 734b932 into master Feb 24, 2016
@304NotModified 304NotModified deleted the internallogger-improvements branch April 12, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io