Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget: Fix archive does not work when date in file name. #1274

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

bhaeussermann
Copy link
Contributor

Fixes #1271

@304NotModified
Copy link
Member

I broke the unit tests :(

See #1251 (also ProcessPendingEvents)

@304NotModified
Copy link
Member

Please rebase with master :)

@304NotModified
Copy link
Member

hmmm there is an "update branch" button?

@bhaeussermann
Copy link
Contributor Author

hmmm there is an "update branch" button?

Is that a bad thing? Oo

@304NotModified
Copy link
Member

Well it does an merge I see. Rebase is of course much nicer :)

Some unannounced new feature of GitHub I guess.

@bhaeussermann
Copy link
Contributor Author

Well it does an merge I see. Rebase is of course much nicer :)

That's odd. My local repository is up-to-date with master.

@304NotModified
Copy link
Member

yes it's now OK. You didn't rebased?

@bhaeussermann
Copy link
Contributor Author

yes it's now OK. You didn't rebased?

I did ;)

@codecov-io
Copy link

Current coverage is 74.65%

Merging #1274 into master will decrease coverage by -0.02% as of efda030

@@            master   #1274   diff @@
======================================
  Files          267     267       
  Stmts        15425   15428     +3
  Branches      1618    1619     +1
  Methods          0       0       
======================================
- Hit          11519   11518     -1
- Partial        378     379     +1
- Missed        3528    3531     +3

Review entire Coverage Diff as of efda030


Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#282...295
  2. +0.09% via ...gingConfiguration.cs#248...261
  3. +0.09% via ...argets/FileTarget.cs#1713...1725
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added this to the 4.3 milestone Mar 2, 2016
304NotModified added a commit that referenced this pull request Mar 2, 2016
FileTarget: Fix archive does not work when date in file name.
@304NotModified 304NotModified merged commit 6881568 into NLog:master Mar 2, 2016
@304NotModified
Copy link
Member

:D great fix just before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants