Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also use logFactory for ThrowConfigExceptions #1299

Merged
merged 2 commits into from
Mar 21, 2016
Merged

Also use logFactory for ThrowConfigExceptions #1299

merged 2 commits into from
Mar 21, 2016

Conversation

304NotModified
Copy link
Member

No description provided.

@304NotModified 304NotModified added this to the 4.3 milestone Mar 9, 2016
@304NotModified 304NotModified force-pushed the fix-logFactory-for-ThrowConfigExceptions branch from 10162ec to 0a23414 Compare March 17, 2016 18:21
@codecov-io
Copy link

Current coverage is 74.99%

Merging #1299 into master will increase coverage by +0.01% as of 430d0a7

@@            master   #1299   diff @@
======================================
  Files          267     267       
  Stmts        15451   15458     +7
  Branches      1622    1622       
  Methods          0       0       
======================================
+ Hit          11586   11593     +7
  Partial        382     382       
  Missed        3483    3483

Review entire Coverage Diff as of 430d0a7

Uncovered Suggestions

  1. +0.10% via ...gingConfiguration.cs#282...295
  2. +0.10% via ...gingConfiguration.cs#248...261
  3. +0.10% via ...argets/FileTarget.cs#1713...1725
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Fix PrecalculateStackTraceUsage threadsafe issues in objectscanner.Fi…
1471656 
…ndReachableObjects

by replacing objectscanner and let SimpleLayout implement IUsesStackTrace
@304NotModified
Also use logFactory for ThrowConfigExceptions
ee15766
@304NotModified 304NotModified force-pushed the fix-logFactory-for-ThrowConfigExceptions branch from 0a23414 to ee15766 Compare March 20, 2016 22:54
@304NotModified 304NotModified mentioned this pull request Mar 20, 2016
Merged
304NotModified added a commit that referenced this pull request Mar 21, 2016
@304NotModified
Merge pull request #1299 from NLog/fix-logFactory-for-ThrowConfigExce…
bd3d08d 
…ptions

Also use logFactory for ThrowConfigExceptions
@304NotModified 304NotModified merged commit bd3d08d into master Mar 21, 2016
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Mar 21, 2016
@304NotModified 304NotModified deleted the fix-logFactory-for-ThrowConfigExceptions branch April 12, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io