Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threadsafe issue of ScanProperties3 #1303

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Fix threadsafe issue of ScanProperties3 #1303

merged 1 commit into from
Mar 17, 2016

Conversation

304NotModified
Copy link
Member

revert changes before breaking unit tests

fixes #1262

@304NotModified 304NotModified changed the title revert changes before breaking unit tests Fix threadsafe issue of ScanProperties3 Mar 16, 2016
@codecov-io
Copy link

Current coverage is 74.91%

Merging #1303 into master will increase coverage by +0.09% as of 934e3a9

@@            master   #1303   diff @@
======================================
  Files          267     267       
  Stmts        15458   15438    -20
  Branches      1622    1620     -2
  Methods          0       0       
======================================
- Hit          11566   11565     -1
+ Partial        383     381     -2
+ Missed        3509    3492    -17

Review entire Coverage Diff as of 934e3a9

Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#282...295
  2. +0.09% via ...gingConfiguration.cs#248...261
  3. +0.08% via ...argets/FileTarget.cs#1713...1725
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added this to the 4.3 milestone Mar 17, 2016
304NotModified added a commit that referenced this pull request Mar 17, 2016
@304NotModified
Merge pull request #1303 from NLog/threadsafe-issue-ScanProperties3
38aef00 
Fix threadsafe issue of ScanProperties3
@304NotModified 304NotModified merged commit 38aef00 into master Mar 17, 2016
@304NotModified 304NotModified deleted the threadsafe-issue-ScanProperties3 branch April 12, 2016 21:33
@snakefoot snakefoot mentioned this pull request Dec 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io