Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require ProviderName attribute when using <connectionStrings> (app.config etc) #1317

Merged
merged 2 commits into from
Mar 22, 2016

Conversation

304NotModified
Copy link
Member

Fixes #1115

Before was needed:

<add name="test_connectionstring_with_providerName" connectionString="some connectionstring" 

providerName="System.Data.SqlClient" <-----------------

/>

even if "DBProvider" was set. E.g.

                databaseTarget .DBProvider = "System.Data.SqlClient"

@304NotModified 304NotModified added this to the 4.3 milestone Mar 21, 2016
@304NotModified 304NotModified force-pushed the DontRequireProviderNameInAppConfig branch from c9f2960 to 07ea331 Compare March 22, 2016 00:01
@304NotModified 304NotModified force-pushed the DontRequireProviderNameInAppConfig branch from 07ea331 to 037bc42 Compare March 22, 2016 00:05
@codecov-io
Copy link

Current coverage is 75.01%

Merging #1317 into master will not affect coverage as of 0c54895

@@            master   #1317   diff @@
======================================
  Files          267     267       
  Stmts        15467   15471     +4
  Branches      1626    1627     +1
  Methods          0       0       
======================================
+ Hit          11602   11606     +4
  Partial        383     383       
  Missed        3482    3482       

Review entire Coverage Diff as of 0c54895


Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#282...295
  2. +0.09% via ...gingConfiguration.cs#248...261
  3. +0.09% via ...argets/FileTarget.cs#1713...1725
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Mar 22, 2016
don't require ProviderName attribute when using <connectionStrings> (app.config etc)
@304NotModified 304NotModified merged commit f114114 into master Mar 22, 2016
@304NotModified
Copy link
Member Author

@304NotModified 304NotModified deleted the DontRequireProviderNameInAppConfig branch April 12, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants