Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test dependency on locale #1393

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Remove test dependency on locale #1393

merged 1 commit into from
Apr 22, 2016

Conversation

luigiberrettini
Copy link
Contributor

Since some tests were not working because relying on a specific locale I fixed them.

NLog version
4.3.0

Work arounds
None

Config when implemented
No changes

@codecov-io
Copy link

Current coverage is 75.17%

Merging #1393 into master will not affect coverage as of 4ca0279

@@            master   #1393   diff @@
======================================
  Files          267     267       
  Stmts        15607   15607       
  Branches      1642    1642       
  Methods          0       0       
======================================
  Hit          11732   11732       
  Partial        383     383       
  Missed        3492    3492       

Review entire Coverage Diff as of 4ca0279


Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#374...387
  2. +0.09% via ...gingConfiguration.cs#340...353
  3. +0.08% via ...argets/FileTarget.cs#1741...1753
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified merged commit 22049b4 into NLog:master Apr 22, 2016
@luigiberrettini luigiberrettini deleted the localeAgnosticTests branch April 22, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants