Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make private tests public #1394

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Make private tests public #1394

merged 1 commit into from
Apr 26, 2016

Conversation

luigiberrettini
Copy link
Contributor

@luigiberrettini luigiberrettini commented Apr 22, 2016 •
edited by 304NotModified
Loading

Since some tests were not public I fixed them.

@codecov-io
Copy link

Current coverage is 75.17%

Merging #1394 into master will not affect coverage as of 01769d3

@@            master   #1394   diff @@
======================================
  Files          267     267       
  Stmts        15607   15607       
  Branches      1642    1642       
  Methods          0       0       
======================================
  Hit          11732   11732       
  Partial        383     383       
  Missed        3492    3492

Review entire Coverage Diff as of 01769d3

Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#374...387
  2. +0.09% via ...gingConfiguration.cs#340...353
  3. +0.08% via ...argets/FileTarget.cs#1741...1753
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Copy link
Member

Why is this needed? Xunit can handle private tests?

@luigiberrettini
Copy link
Contributor Author

XUnit handles them, but if you did not do it on purpose it is common to have public tests

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Apr 26, 2016
@304NotModified 304NotModified added this to the 4.3.2 milestone Apr 26, 2016
@304NotModified
Copy link
Member

Thanks, will merge this for consistency reasons.

@304NotModified 304NotModified merged commit 22aac54 into NLog:master Apr 26, 2016
@luigiberrettini luigiberrettini deleted the publicTests branch April 27, 2016 07:29
304NotModified pushed a commit that referenced this pull request Apr 30, 2016
@luigiberrettini @304NotModified
Make test methods public (#1394)
b26ccd6 
 for consistency reasons.
304NotModified pushed a commit that referenced this pull request Apr 30, 2016
@luigiberrettini @304NotModified
Make test methods public (#1394)
abe81d4 
 for consistency reasons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luigiberrettini @codecov-io @304NotModified