Allow comma separated values (List<T>) for Layout Renderers/Targets/Layouts

[304NotModified]

Support voor comma separated list,

e.g.

supported:

• Generic List (List<T>), with the following types:
  • C# built in types (string, int, double, object)
  • enum (use shortname)
  • culture, encoding, Type
  • not supported: Layout

Not supported:

• Arrays
• Non-generic List
• IList<T> / IList
• IEnumerable<T> / IEnumerable

UPDATE support added for

• IList<T> / IList
• IEnumerable<T> / IEnumerable
• ISet<T> / HashSet<T>
• See Support Generic (I)List and (I)Set for Target/Layout/Layout renderers properties #1782

Example:

${layoutrenderer-with-list:enums=Ignore, Neutral, ignore}

[LayoutRenderer("layoutrenderer-with-list")]
public class LayoutRendererWithListParam : LayoutRenderer
{
    public List<FilterResult> Enums { get; set; }
   protected override void Append(StringBuilder builder, LogEventInfo logEvent)
   {
       ...
   }
}

TO DO

• escape comma -> backtick
• replace escape with optional quoted
• add unit test for multiple enum

---

This change is

[bhaeussermann]

What if it's a flags-enum, but flagsEnumAllowed is false? The else-part would then execute with the flags-enum.
Must it not just return false in this case?

[bhaeussermann]

How about adding a test for parsing a list of values of a flag-enum?

[304NotModified]

Good idea

[bhaeussermann]

Any idea why the test coverage dropped so dramatically? I don't seem to be able to view the codecov diff.

[304NotModified]

Any idea why the test coverage dropped so dramatically? I don't seem to be able to view the codecov diff.

It did not. 75.30% (+<.01%) compared to 717373a

but this PR has "only" 74.29% coverage

[304NotModified]

I will remove the ecape and will move to a optional quoted approach,

eg. a,b,c or 'a,b',c

Have to implemented that

[codecov-io]

Current coverage is 81% (diff: 96%)

Merging #1439 into master will increase coverage by <1%

@@             master      #1439   diff @@
==========================================
  Files           277        278     +1   
  Lines         17780      18230   +450   
  Methods        2785       2823    +38   
  Messages          0          0          
  Branches       2024       2098    +74   
==========================================
+ Hits          14332      14748   +416   
- Misses         2996       3006    +10   
- Partials        452        476    +24   

Powered by Codecov. Last update f900e35...61b4a72

[304NotModified]

docs: https://github.com/NLog/NLog/wiki/Properties-constraints-for-custom-extensions