LogReceiverWebServiceTarget is leaking communication channels #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2016 11:43
…e communication channel was never closed until the receive timeout expired
Current coverage is 76%@@ master #1547 diff @@
==========================================
Files 269 269
Lines 16260 16266 +6
Methods 2604 2604
Messages 0 0
Branches 1770 1770
==========================================
+ Hits 12366 12371 +5
- Misses 3495 3496 +1
Partials 399 399
|
|
Thanks for the PR! |
|
It's online! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sending log messages over the communication channel, a completion event is raised to close the communication channel. In this event handler the "sender" parameter is cast to the wrong type hence the channel never get closed until the "receive timeout" expire (from the WCF binding, default to 10 minutes)