Bugfix: Throw configException when registering invalid extension assembly/type. #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gistering an assembly or type with the <extensions> Element (with <nlog throwConfigExceptions='true'>).
Add two new testcases for invalid extension registration.
|
Strange, it works on my local machine |
Current coverage is 76% (diff: 88%)@@ master #1553 diff @@
==========================================
Files 269 269
Lines 16266 16284 +18
Methods 2605 2605
Messages 0 0
Branches 1769 1771 +2
==========================================
+ Hits 12367 12388 +21
+ Misses 3487 3482 -5
- Partials 412 414 +2
|
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508. Supersedes #1517