Added option to not render empty literals on nested json objects #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnkors
commented
Aug 4, 2016
johnkors
commented
- Nested objects of null value were rendered as empty json literals. Added option to remove these.
|
Thanks! We review it! |
| @@ -68,6 +69,11 @@ public JsonLayout() | |||
| public bool SuppressSpaces { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the option to render the empty object value {} | |||
| /// </summary> | |||
| public bool RenderEmptyLiteral { get; set; } | |||
There was a problem hiding this comment.
I was thinking of 'RenderEmptyObject`? What do you think?
There was a problem hiding this comment.
Yeah, better naming!
Current coverage is 76% (diff: 100%)@@ master #1580 diff @@
==========================================
Files 270 270
Lines 16318 16325 +7
Methods 2611 2612 +1
Messages 0 0
Branches 1775 1777 +2
==========================================
+ Hits 12432 12440 +8
Misses 3483 3483
+ Partials 403 402 -1
|
| sb.Append("}"); | ||
| var result = sb.ToString(); | ||
|
|
||
| if (string.IsNullOrEmpty(result.Trim()) && !RenderEmptyObject) |
There was a problem hiding this comment.
It's maybe even better to keep a boolean value tracking the "empty state"?
Less String operations are better (e.g. trim and string comparisons)
There was a problem hiding this comment.
Ah, okay! Yeah, not used to thinking performance up front :) Thanks. Will push an update.
There was a problem hiding this comment.
Cool!
Well pretty important stuff to most of the users ;)
|
One note, let me know what you think |
|
perfect! 👍 thanks! |
|
Added on wiki https://github.com/NLog/NLog/wiki/JsonLayout |
|
4.3.7 is online: https://www.nuget.org/packages/NLog/4.3.7 |
304NotModified
pushed a commit
that referenced
this pull request
Aug 14, 2016
* Added option to not render empty literals on nested json objects (#1580) * Added option to not render empty objects on nested json objects * Add support for name parameter on (#1578) * Bugfix: Use the culture when rendering the layout (#1556) * Added unit tests * Use the correct culture for rendering the string * fix SL / fix tests * fix culture * split IFormatProvider and CultureInfo * added related test * update/expand tests * fix xplat * Allow overwriting possible nlog configuration file paths (#1469) * Allow overwriting possible nlog configuration file paths * Redesign after review * Added tests * Improvements after review * move statics to XmlLoggingConfiguration * FileTarget: Performance improvement for CleanupInvalidFileNameChars (#1582) * FileTarget: Performance improvement for CleanupInvalidFileNameChars * Added unit test * Update for NLog 4.3.7 * Update README.md [skip ci] * fix unit test (#1589) * Misc. fixes for .NET Core * Remove wrap projects
304NotModified
added
the
documentation done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.