Don't stop logging when there is an invalid layoutrenderer in the layout #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76% (diff: 100%)@@ master #1583 diff @@
==========================================
Files 270 270
Lines 16413 16423 +10
Methods 2621 2621
Messages 0 0
Branches 1787 1788 +1
==========================================
+ Hits 12522 12525 +3
+ Misses 3488 3485 -3
- Partials 403 413 +10
|
|
Maybe add in the future the option to to set the option for replacement: empty (current), space, error, exception (enable throwExceptions) |
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we made a typo or forget to include some NLog extensions, there is a change that logging won't work at all! e.g. setting the Message of a filetarget on
{logger} {messagge}(notice the typo), than the filetarget won't log anything!This is unneeded and now we are skipping the invalid parts. The invalid parts are replace with an empty string.
If throwExceptions or throwConfigExceptions is
true, there will be still an error thrownThis change is