Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clear internallog when reading XML config #1585

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Aug 5, 2016

Goals:

  • More clear if there are errors
  • More clear how many errors
  • More clear what exactly failed and what the consequences are

This change is Reviewable

@304NotModified 304NotModified added this to the 4.4 milestone Aug 5, 2016
@codecov-io
Copy link

codecov-io commented Aug 6, 2016

Current coverage is 81% (diff: 72%)

Merging #1585 into master will decrease coverage by <1%

@@             master      #1585   diff @@
==========================================
  Files           273        278     +5   
  Lines         18037      19019   +982   
  Methods        2774       2936   +162   
  Messages          0          0          
  Branches       2072       2310   +238   
==========================================
+ Hits          14684      15457   +773   
- Misses         2891       3071   +180   
- Partials        462        491    +29   

Sunburst

Powered by Codecov. Last update 731d2f4...59df3e5

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Nov 15, 2016
@304NotModified 304NotModified force-pushed the more-clear-internallog-parse-config branch from e04b704 to 45762aa Compare November 23, 2016 19:57
Advise to include NLog.Web in exception message.
@304NotModified 304NotModified force-pushed the more-clear-internallog-parse-config branch from 45762aa to 59df3e5 Compare November 23, 2016 19:59
@304NotModified 304NotModified changed the title [WIP] More clear internallog when reading XML config More clear internallog when reading XML config Nov 24, 2016
@304NotModified 304NotModified merged commit 9903e03 into master Nov 24, 2016
@304NotModified 304NotModified deleted the more-clear-internallog-parse-config branch November 24, 2016 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature nlog-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants