FileTarget Bugfix: writing to non-existing drive is slowing down NLog a lot #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76% (diff: 100%)@@ master #1621 diff @@
==========================================
Files 272 272
Lines 16662 16668 +6
Methods 2648 2648
Messages 0 0
Branches 1839 1839
==========================================
- Hits 12721 12711 -10
- Misses 3521 3522 +1
- Partials 420 435 +15
|
300 messages => 60 seconds. Non 50 miliseconds (even in debug modes)
304NotModified
force-pushed
the
fix-delay-nonexisting-disk
branch
from
13e1e5d
to
c4ff0b4
Compare
|
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to 'A' was slowing down a lot
300 messages => 60 seconds. Now 50 miliseconds (even in debug modes)
This change is