Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent possible crash when archiving in folder with non-archived files #1632

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Sep 10, 2016

Including tests (but failed to exactly find got the same exception)

fixes #1436


This change is Reviewable

Including tests (but failed to exactly find got the same exception)
@304NotModified 304NotModified added file-target bug Bug report / Bug fix labels Sep 10, 2016
@304NotModified 304NotModified added this to the 4.3.9 milestone Sep 10, 2016
@codecov-io
Copy link

codecov-io commented Sep 10, 2016

Current coverage is 76% (diff: 0%)

Merging #1632 into master will increase coverage by <1%

@@             master      #1632   diff @@
==========================================
  Files           272        272          
  Lines         16670      16675     +5   
  Methods        2649       2649          
  Messages          0          0          
  Branches       1839       1840     +1   
==========================================
+ Hits          12713      12730    +17   
+ Misses         3522       3512    -10   
+ Partials        435        433     -2   

Sunburst

Powered by Codecov. Last update b8362f5...6760a55

@304NotModified 304NotModified changed the title Fix for same archive name as filename. Prevent possible crash when archiving in folder with non-archived files Sep 12, 2016
@304NotModified 304NotModified merged commit 4374462 into master Sep 12, 2016
@304NotModified 304NotModified deleted the fix-dash-archive-bug branch September 12, 2016 19:50
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants