FilePathLayout - Reduce memory-allocation for cleanup of filename #1745
Conversation
Current coverage is 80% (diff: 96%)@@ master #1745 diff @@
==========================================
Files 274 274
Lines 17066 17079 +13
Methods 2698 2699 +1
Messages 0 0
Branches 1910 1912 +2
==========================================
+ Hits 13686 13711 +25
- Misses 2931 2932 +1
+ Partials 449 436 -13
|
snakefoot
changed the title
snakefoot
force-pushed
the
FilePathLayoutCachePrev
branch
2 times, most recently
from
9f307d9
to
2a4aa22
Compare
| @@ -77,6 +77,9 @@ internal class FilePathLayout : IRenderable | |||
|
|
|||
| private bool _cleanupInvalidChars; | |||
|
|
|||
| private string _cachedPrevRawFileName; | |||
| private string _cachedPrevCleanFileName; | |||
There was a problem hiding this comment.
We should document (xmldoc) that _cachedPrevCleanFileName is a pair with _cachedPrevRawFileName, right?
There was a problem hiding this comment.
Yes they are working together. Will update the xml-doc
| if ((!_cleanupInvalidChars || cleanedFixedResult != null) && _filePathKind == FilePathKind.Absolute) | ||
| return rawFileName; // Skip clean filename string-allocation | ||
|
|
||
| if (string.CompareOrdinal(_cachedPrevRawFileName, rawFileName) == 0 && _cachedPrevCleanFileName != null) |
There was a problem hiding this comment.
In case of performance, the check _cachedPrevCleanFileName != null should be on the left?
There was a problem hiding this comment.
_cachedPrevCleanFileName will never be null, and when it is then _cachedPrevRawFileName is also null. I just have a secret agenda when it comes to the PR with PoolSetup :)
…le (Reuse clean-filename when raw-filename is unchanged)
snakefoot
force-pushed
the
FilePathLayoutCachePrev
branch
from
2a4aa22
to
acc8071
Compare
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
|
Thanks again! |
Reuse clean-filename when raw-filename is unchanged.
This change is