ConsoleTarget - DetectConsoleAvailable - Disabled by default #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again @snakefoot ! |
Current coverage is 80% (diff: 100%)@@ master #1778 diff @@
==========================================
Files 276 277 +1
Lines 17711 17780 +69
Methods 2768 2785 +17
Messages 0 0
Branches 2020 2024 +4
==========================================
+ Hits 14271 14298 +27
- Misses 2987 3031 +44
+ Partials 453 451 -2
|
304NotModified
added
the
documentation done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1773
DetectConsoleAvailable fails to handle the situation where the console application stdout is used for file logging, and the console application runs as a Windows Service or within the Task Scheduler.
DetectConsoleAvailable has been designed to disable the console, when the console application is running as windows service. And not for doing the funky chicken with stdout support.
This change is