Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget - Close stale file handles outside archive mutex lock #1809

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Dec 2, 2016

Will increase chance that all processes has released their handles before doing archive operation (Have verified that #1513 is still working)


This change is Reviewable

@codecov-io
Copy link

Current coverage is 81% (diff: 100%)

Merging #1809 into master will decrease coverage by <1%

@@             master      #1809   diff @@
==========================================
  Files           274        274          
  Lines         18256      18256          
  Methods        2834       2834          
  Messages          0          0          
  Branches       2091       2091          
==========================================
- Hits          14865      14862     -3   
- Misses         2924       2925     +1   
- Partials        467        469     +2   

Sunburst

Powered by Codecov. Last update 6b197e5...74b2ba7

@304NotModified 304NotModified added this to the 4.4 milestone Dec 4, 2016
@304NotModified 304NotModified changed the base branch from master to release/4.4 December 4, 2016 13:10
@304NotModified 304NotModified merged commit 4317e2e into NLog:release/4.4 Dec 4, 2016
@304NotModified
Copy link
Member

thanks! also for checking #1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-archiving Issues with archiving with the file target file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants