Improve [Obsolete] warnings - include the Nlog version when it became obsolete #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document on XML comment as well as the [Obsolete] attribute the NLog version where a class, method or property was marked as obsolete. This might help in the future releases to evaluate if an element should be removed completely from the code and provide the users with more information.
Current coverage is 82% (diff: 100%)@@ master #1814 diff @@
==========================================
Files 274 275 +1
Lines 18256 18367 +111
Methods 2834 2846 +12
Messages 0 0
Branches 2091 2106 +15
==========================================
+ Hits 14851 15001 +150
+ Misses 2923 2887 -36
+ Partials 482 479 -3
|
|
Good idea. Maybe it's event better to use the real version (we should find it with git) and update #531? |
Updated the XML documentation and the obsolete messages with the actual versions that certain elements marked as obsolete.
|
Thanks! Great work! |
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document on XML comment as well as the [Obsolete] attribute the NLog
version where a class, method or property was marked as obsolete.
This might help in the future releases to evaluate if an element should
be removed completely from the code and it provides the users with more
information.
This change is