Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better parsing for Layouts with int/bool type. #1815

Merged
merged 2 commits into from
Jan 13, 2017

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Dec 4, 2016

Added helpers layout.RenderInt, RenderBool and RenderShort

included logging to internal logger

in the future maybe throwing also exception

This change is Reviewable

@304NotModified 304NotModified added this to the 4.4 milestone Dec 4, 2016
@304NotModified 304NotModified force-pushed the handle-numeric-layout-properties-better branch 2 times, most recently from bb20c44 to 2e5e002 Compare December 4, 2016 15:16
@304NotModified 304NotModified modified the milestones: 4.4, 4.4.1 Dec 4, 2016
@304NotModified 304NotModified added enhancement Improvement on existing feature work in progress labels Dec 4, 2016
@304NotModified 304NotModified force-pushed the handle-numeric-layout-properties-better branch from 2e5e002 to 35a0b67 Compare December 9, 2016 23:15
@304NotModified 304NotModified modified the milestones: 4.4.1, 4.4.2 Dec 24, 2016
@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 83% (diff: 51%)

Sunburst

No coverage report found for master at 27e03e6.

Powered by Codecov. Last update 27e03e6...25b3d41

@304NotModified 304NotModified force-pushed the handle-numeric-layout-properties-better branch from 0cd8f0f to 25b3d41 Compare January 13, 2017 16:06
@304NotModified 304NotModified merged commit c65edc2 into master Jan 13, 2017
@304NotModified 304NotModified deleted the handle-numeric-layout-properties-better branch January 14, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants