Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added condition to AutoFlushWrappper #1817

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

nazim9214
Copy link
Contributor

@nazim9214 nazim9214 commented Dec 4, 2016

fixes #1712

Added condition property to AutoFlushTargetWrapper, to allow autoflush on special conditions.


This change is Reviewable

@304NotModified
Copy link
Member

Thanks! 👍 👍

@304NotModified
Copy link
Member

@nazim9214 Do you have time to add this to the wiki? If so, then we could include it for NLog 4.4. Please also add an example :)

Please add "introduced in NLog 4.4" .

I have still some documentation for NLog 4.4 to do, so working on that first

@codecov-io
Copy link

codecov-io commented Dec 4, 2016

Current coverage is 81% (diff: 100%)

Merging #1817 into master will increase coverage by <1%

@@             master      #1817   diff @@
==========================================
  Files           274        274          
  Lines         18256      18264     +8   
  Methods        2834       2835     +1   
  Messages          0          0          
  Branches       2091       2092     +1   
==========================================
+ Hits          14851      14873    +22   
- Misses         2923       2924     +1   
+ Partials        482        467    -15   

Sunburst

Powered by Codecov. Last update 6b197e5...6283a9d

@nazim9214
Copy link
Contributor Author

@304NotModified yes, i will change the wiki

@nazim9214
Copy link
Contributor Author

@304NotModified
Copy link
Member

looks great, I have enabled syntax highlighting :)

@304NotModified 304NotModified added this to the 4.4 milestone Dec 4, 2016
@304NotModified 304NotModified added documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) needs documentation on wiki labels Dec 4, 2016
@304NotModified
Copy link
Member

Thanks!

@snakefoot
Copy link
Contributor

New property FlushOnConditionOnly has been added to AutoFlushWrapper in NLog 4.6.6 . See also #3513

It ensures that messages are NOT flushed when calling NLog.LogManager.Flush() or NLog.LogManager.Shutdown()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature needs documentation on wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants