Standarise implementation of events #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the project there are a number of different formats on how events are defined in the code. This is a effort to standarise the way the events are implemented and named in the project without breaking the public interface.
Current coverage is 82% (diff: 83%)@@ master #1848 diff @@
==========================================
Files 277 277
Lines 18413 18423 +10
Methods 2850 2853 +3
Messages 0 0
Branches 2116 2115 -1
==========================================
+ Hits 15045 15057 +12
- Misses 2891 2894 +3
+ Partials 477 472 -5
|
|
Reviewed it, this is a nice improvement, thanks! Hopefully I get it easily merged into .NET Core branch (coreCLR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the project there are a number of different formats on how events are defined in the code. This is a effort to standarise the way the events are implemented and named in the project without breaking the public
interface.
This change is