FileTarget - Failing to delete old archive files, should not stop logging #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
FileTargetMaxArchiveFiles
branch
from
ba99fb8
to
6472e7f
Compare
Current coverage is 82% (diff: 53%)@@ master #1867 diff @@
==========================================
Files 276 276
Lines 18503 18519 +16
Methods 2859 2860 +1
Messages 0 0
Branches 2137 2143 +6
==========================================
Hits 15094 15094
- Misses 2917 2928 +11
- Partials 492 497 +5
|
snakefoot
force-pushed
the
FileTargetMaxArchiveFiles
branch
from
6472e7f
to
98ce8e4
Compare
snakefoot
force-pushed
the
FileTargetMaxArchiveFiles
branch
from
98ce8e4
to
0b4775e
Compare
|
Thanks! |
304NotModified
added
the
file-archiving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1866
Have also changed the compression logic code from waiting forever to "only" 12 secs.
This change is