Inject basedir - allow injecting IAppDomain #1906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAppDomain
property#if
stuff and handle empty properties ofIAppDomain
Goal: inject basedir in another package, by using the
IAppDomain
This change is
As the interface is altered for SL, this could a breaking change for SL. But i'm pretty sure there aren't custom implementations of IAppDomain for SL in custom code.