Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored- & ConsoleTarget - Enable OptimizeBufferReuse by default #1907

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Colored- & ConsoleTarget - Enable OptimizeBufferReuse by default #1907

merged 1 commit into from
Jun 23, 2017

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 13, 2017 •
edited by 304NotModified
Loading

Waiting for NLog ver. 4.5

This change is Reviewable

@304NotModified 304NotModified added this to the 4.5 milestone Jan 13, 2017
@codecov-io
Copy link

codecov-io commented Jan 13, 2017 •
edited
Loading

Current coverage is 81% (diff: 69%)

Merging #1907 into master will decrease coverage by <1%

@@             master      #1907   diff @@
==========================================
  Files           285        285          
  Lines         19398      19400     +2   
  Methods        2946       2946          
  Messages          0          0          
  Branches       2256       2256          
==========================================
- Hits          15803      15772    -31   
- Misses         3058       3090    +32   
- Partials        537        538     +1

Sunburst

Powered by Codecov. Last update c65edc2...88a6532

@304NotModified
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@304NotModified 304NotModified changed the title ConsoleTarget - Enable OptimizeBufferReuse by default Colored- & ConsoleTarget - Enable OptimizeBufferReuse by default Jan 13, 2017
@304NotModified 304NotModified merged commit abce415 into NLog:master Jun 23, 2017
@304NotModified 304NotModified modified the milestones: 4.5, 4.5 beta ? Oct 10, 2017
@snakefoot snakefoot deleted the ConsoleOptimizeBufferReuse branch October 10, 2017 20:42
@snakefoot snakefoot mentioned this pull request Nov 23, 2017
Closed
@snakefoot
Copy link
Contributor Author

@304NotModified Updated documentation:

https://github.com/NLog/NLog/wiki/Console-target
https://github.com/NLog/NLog/wiki/ColoredConsole-target

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Jan 14, 2018
@snakefoot snakefoot modified the milestones: 4.5 beta ?, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console-target documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) needs documentation on wiki performance
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snakefoot @codecov-io @304NotModified