Call NLogPackageLoader.Preload (static) for NLog packages on load #1917
Conversation
304NotModified
force-pushed
the
ext-activate
branch
2 times, most recently
from
d85621d
to
c11e7e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 285 285
Lines 19592 19628 +36
Branches 2290 2293 +3
=======================================
+ Hits 15980 16021 +41
+ Misses 3060 3040 -20
- Partials 552 567 +15Continue to review full report at Codecov.
|
| InternalLogger.Warn(e,"Preload invoked for '{0}' failed", type.FullName); | ||
| } | ||
|
|
||
| InternalLogger.Debug("Preload succesfully invoked for '{0}'", type.FullName); |
There was a problem hiding this comment.
This line will be executed, even if invoke has been failed. I suggest that move this line to the line 267 (after the invoke).
| } | ||
| else | ||
| { | ||
| InternalLogger.Debug("NLogPackageLoader preload method, but isn't static"); |
There was a problem hiding this comment.
Log message would be improved as:
NLogPackageLoader contains a preload method, but it isn't static.
| } | ||
|
|
||
| /// <summary> | ||
| /// Call Preload for <paramref name="type"/>. The method should be static. |
There was a problem hiding this comment.
It would be improved as:
Calls the preload method for <paramref name="type"/>. The preload method should be static.
304NotModified
force-pushed
the
ext-activate
branch
from
c11e7e8
to
3322076
Compare
304NotModified
force-pushed
the
ext-activate
branch
from
3322076
to
f954491
Compare
|
@UgurAldanmaz thanks for the review |
This change is
related: #1530