RetryingWrapper - Allow closing target, even when busy retrying

[snakefoot]

If wrapped target is working on retrying for ever, then it should not block one from closing target.

This is a breaking change, as the RetryingWrapper is not sealed. Has to wait for NLog 5.0

---

This change is 

[codecov-io]

Current coverage is 82% (diff: 92%)

Merging #1926 into master will increase coverage by <1%

@@             master      #1926   diff @@
==========================================
  Files           285        285          
  Lines         19496      19535    +39   
  Methods        2961       2962     +1   
  Messages          0          0          
  Branches       2277       2286     +9   
==========================================
+ Hits          15879      15927    +48   
+ Misses         3072       3060    -12   
- Partials        545        548     +3   

Powered by Codecov. Last update 6ba58c8...63493c4

[304NotModified]

And thanks again!!

[304NotModified]

This is a breaking change, as the RetryingWrapper is not sealed. Has to wait for NLog 5.0

Oops missed that one.

[304NotModified]

isn't .RetryingWrapper.Write calling RetryingWrapper.WriteAsyncThreadSafe (inidrect) and so it's a non-breaker?

• WriteAsyncThreadSafe calls Write in Target

[304NotModified]

#1933 should fix this IMO. I assume that the sleep-retry logic is safe without lock.

[snakefoot]

#1933 should fix this IMO. I assume that the sleep-retry logic is safe without lock.

@304NotModified When overriding WriteAsyncThreadSafe(), then it will never reach the normal Write(). This is intended as the normal Write() is called after having taken target-lock. It is the target-lock I want to avoid as it blocks one from flushing and closing the target. If you re-introduce the RetryingTargetWrapper-Write() again then it will never be reached.

The sleep-retry-logic was before protected against reordering by the Write-Target-lock, with this change then it is protected against reordering by the RetrySyncObject-lock.