Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTarget - KeepFileOpen should watch for file deletion, but not every second #1942

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 4, 2017

Avoid timer every second. Restore OpenFileCacheTimeout-autoClosingTimer when needed. Small fix to #1878


This change is Reviewable

…very second. Restore OpenFileCacheTimeout timer when needed.
@snakefoot snakefoot changed the title FileTarget - KeepFileOpen should watch for file deletio, but not every second FileTarget - KeepFileOpen should watch for file deletion, but not every second Feb 4, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fc487be). Click here to learn what that means.

@@           Coverage Diff            @@
##             master   #1942   +/-   ##
========================================
  Coverage          ?     82%           
========================================
  Files             ?     285           
  Lines             ?   19548           
  Branches          ?    2286           
========================================
  Hits              ?   15942           
  Misses            ?    3058           
  Partials          ?     548

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc487be...823b137. Read the comment docs.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Feb 4, 2017
@304NotModified 304NotModified added this to the 4.4.2 milestone Feb 4, 2017
@304NotModified 304NotModified merged commit abf4847 into NLog:master Feb 4, 2017
@snakefoot snakefoot deleted the FileTargetAutoCloseTimer branch October 10, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants