Target.Close() - Extra logging to investigate shutdown order #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
TargetCloseTargetLogging
branch
2 times, most recently
from
5fb0fd1
to
b049139
Compare
Codecov Report
@@ Coverage Diff @@
## master #2007 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 285 285
Lines 19590 19592 +2
Branches 2290 2290
=======================================
- Hits 15992 15979 -13
- Misses 3047 3062 +15
Partials 551 551Continue to review full report at Codecov.
|
snakefoot
force-pushed
the
TargetCloseTargetLogging
branch
from
b049139
to
9efb5f2
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1998 revealed that logging could be improved, when diagnosing NLog Configuration-change-issues.