LogFactory - Ensure to flush and close on shutdown #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LogFactoryLoggingShutdown
branch
from
a73e303
to
41f42c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 286 286
Lines 19658 19663 +5
Branches 2296 2297 +1
=======================================
+ Hits 16042 16066 +24
+ Misses 3047 3043 -4
+ Partials 569 554 -15Continue to review full report at Codecov.
|
|
Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced with #1906 and reported in #1998 (Abused the medium-trust-AppDomain-unit-test to verify flush is done properly on AppDomain-unload)