WebServiceTarget - Fix boolean parameter conversion for Xml and Json (lowercase) & merged the JSON serializer code into DefaultJsonSerializer

[snakefoot]

And also merged the JSON serializer code into DefaultJsonSerializer (Trying to fix #2016)

This also fixes the handling of boolean for the DefaultJsonSerializer, so it is now lowercase without being json-encoded (Fixed the existing test to be case-sensitive). This also fixes the handling of all non-string-objects in DefaultJsonSerializer (Ex DateTime or Guid), so when converted to string, then they are actually json-encoded as strings (Added new tests to verify this).

This also reduces the number of string-allocations in DefaultJsonSerializer, when serializing standard strings (better performance). The original EscapeString (would allocate StringBuilder and call ToString for every value) has been replaced by JsonStringEscape (only allocates StringBuilder when needed).

Modified the use of TypeCode, so it should also work on NET Core (Now using System.Convert.GetTypeCode instead of System.Type.GetTypeCode)

Will probably gives lots of conflicts in the NLog 5.0 Core-Branch (as you have already made change to fix the previous use of System.Type.GetTypeCode). But since I have moved the old code to XmlHelper.cs, then it should be easy to fix.

[codecov-io]

Codecov Report

Merging #2017 into master will decrease coverage by <1%.
The diff coverage is 81%.

@@           Coverage Diff           @@
##           master   #2017    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         286     286            
  Lines       19665   19663     -2     
  Branches     2297    2309    +12     
=======================================
- Hits        16072   16028    -44     
- Misses       3037    3069    +32     
- Partials      556     566    +10

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f317b...0e833ea. Read the comment docs.

[snakefoot]

Have now created XmlHelper.XmlConvertToString(object value) that uses XmlConvert.ToString() as much as possible. And changed Log4JXmlEventLayoutRenderer to also use XmlConvertToString for writing properties.

Have also added Xml-string-validation to WebServiceTarget.HttpPostXmlFormatterBase, so it will automatically strip invalid-xml-characters for the xml-paramters. Extended the existing unit-test to show that it also works.

Also added handling for DateTime-formatting, but it seems to be a dangerous minefield (Many different formatting options, and we only have one). But since one can always specify parameter as string, and provide a custom format string, then it will not break anything. The handling of DateTime-formatting is only applied when having specified the parameter as System.DateTime (Just like the handling of Boolean-formatting is only applied when having the parameter as System.Boolean).

Maybe someone can answer why the existing unit-test enforced the Microsoft JSON-datacontract-formatter, instead of the newer (and default) JSON-NET-formatter?

Formatters.JsonFormatter.UseDataContractJsonSerializer = true

I had to change it to the default JSON-NET-formatter for the DateTime-parameter to work (Instead of using microsoft-wcf-format)

[304NotModified]

Thanks, have to check more in-depth, will try to do this week

[304NotModified]

maybe we should tell this is the same as ParameterType (with <see)

[snakefoot]

Fixed

[304NotModified]

is working with typecode better than type? Any idea of the .NET core support?

[snakefoot]

Think switch-statement is faster than dictionary-lookup. System.Convert.GetTypeCode should also work in NET Core (It is System.Type.GetTypeCode that has been removed).

[304NotModified]

thanks!