Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebServiceTarget - Avoid re-throwing exceptions in async completion method #2040

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

snakefoot
Copy link
Contributor

Attempt to resolve #2035

@codecov-io
Copy link

Codecov Report

Merging #2040 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2040   +/-   ##
======================================
  Coverage      82%     82%           
======================================
  Files         286     286           
  Lines       19663   19663           
  Branches     2309    2309           
======================================
  Hits        16042   16042           
  Misses       3056    3056           
  Partials      565     565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9e2b2...cdbd236. Read the comment docs.

@304NotModified
Copy link
Member

Why do we need this? If throwexceptions is enabled, we like to get exceptions?

@snakefoot
Copy link
Contributor Author

snakefoot commented Mar 30, 2017

@304NotModified We like synchronous exceptions, but not the async ones that cannot be caught and crashes the application.

@304NotModified 304NotModified added this to the 4.4.6 milestone Mar 30, 2017
@304NotModified 304NotModified added enhancement Improvement on existing feature webservice-target labels Mar 30, 2017
@304NotModified
Copy link
Member

OK clear, thanks!

@304NotModified 304NotModified merged commit 7c58360 into NLog:master Mar 30, 2017
@snakefoot snakefoot deleted the WebServiceTargetAsyncCrash branch October 10, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature webservice-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants