Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoFlushTargetWrapper - Added AsyncFlush property #2042

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 30, 2017

Allow the following setup to work out of the box:

  <target name="mailautoflush" xsi:type="AutoFlushWrapper" condition="level >= LogLevel.Error">
    <target name="mailbuffer" xsi:type="BufferingWrapper" bufferSize="1000000">
      <target name="mail" xsi:type="Mail" ... />
    </target>
  </target>

Before the BufferingWrapper would capture the LogEvent, so it wouldn't reach the final target, so the attached flush-operation was not executed. Disabling AsyncFlush will make AutoFlushWrapper work together with BufferingWrapper.

@snakefoot snakefoot force-pushed the AutoFlushTargetBufferWrapper branch from db0f42b to 9b1f363 Compare March 30, 2017 18:00
@codecov-io
Copy link

codecov-io commented Mar 30, 2017

Codecov Report

Merging #2042 into master will decrease coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2042    +/-   ##
=======================================
- Coverage      82%     81%   -<1%     
=======================================
  Files         286     286            
  Lines       19663   19678    +15     
  Branches     2309    2312     +3     
=======================================
- Hits        16042   16016    -26     
- Misses       3056    3096    +40     
- Partials      565     566     +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9e2b2...9b1f363. Read the comment docs.

@304NotModified
Copy link
Member

Good catch!

@304NotModified 304NotModified merged commit 4cc8773 into NLog:master Mar 30, 2017
@304NotModified 304NotModified added this to the 4.4.6 milestone Mar 30, 2017
@304NotModified 304NotModified added enhancement Improvement on existing feature feature labels Mar 30, 2017
@304NotModified
Copy link
Member

@snakefoot snakefoot deleted the AutoFlushTargetBufferWrapper branch October 10, 2017 20:39
@NLog NLog deleted a comment from FixRM Aug 4, 2023
@NLog NLog deleted a comment from FixRM Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Improvement on existing feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants