JsonLayout - IncludeMdc and IncludeMdlc #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
JsonLayoutIncludeProperties
branch
3 times, most recently
from
ffd634b
to
9542609
Compare
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
+ Coverage 81% 81% +<1%
=======================================
Files 289 289
Lines 19957 19983 +26
Branches 2360 2364 +4
=======================================
+ Hits 16176 16239 +63
+ Misses 3175 3137 -38
- Partials 606 607 +1 |
snakefoot
force-pushed
the
JsonLayoutIncludeProperties
branch
3 times, most recently
from
39cc30c
to
064b748
Compare
snakefoot
force-pushed
the
JsonLayoutIncludeProperties
branch
4 times, most recently
from
f190057
to
772c0cf
Compare
snakefoot
force-pushed
the
JsonLayoutIncludeProperties
branch
from
772c0cf
to
b8fd4c8
Compare
|
Guess something is wrong with NuGet. Recommended workaround is to upgrade to NuGet 3.5 and amend the nuget restore command like this:
http://help.appveyor.com/discussions/problems/6660-nuget-packages-sporadically-failing-to-download |
|
thx, will do a restart for now |
304NotModified
approved these changes
May 17, 2017
| @@ -126,15 +126,13 @@ internal static string XmlConvertToString(object value) | |||
| /// <param name="value">Object value</param> | |||
| /// <param name="objTypeCode">Object TypeCode</param> | |||
| /// <returns>Object value converted to string</returns> | |||
| internal static string XmlConvertToString(object value, out TypeCode objTypeCode) | |||
|
👍 👍 @snakefoot |
|
If IncludeMdc or IncludeMdlc is true then the layout is no longer ThreadAgnostic. |
|
I think you're right! |
|
Could you please create a new issue? It's OK to keep the description short. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #2108 (Missing NDC)