NdlcLayoutRenderer - Nested Diagnostics Logical Context

[snakefoot]

Make it easier to support Microsoft ILogger BeginScope (And maybe resolve #1615 and #1181)

Maybe rename to Nested Diagnostics Logical Context (NDLC) ?

[codecov]

Codecov Report

Merging #2110 into master will increase coverage by <1%.
The diff coverage is 95%.

@@           Coverage Diff           @@
##           master   #2110    +/-   ##
=======================================
+ Coverage      81%     81%   +<1%     
=======================================
  Files         289     291     +2     
  Lines       19957   20069   +112     
  Branches     2360    2376    +16     
=======================================
+ Hits        16176   16323   +147     
+ Misses       3175    3140    -35     
  Partials      606     606

[304NotModified]

Cool! Great!

I propose:

• the class name for the context: NestedDiagnosticsLogicalContext (consistent with NestedDiagnosticsContext , MappedDiagnosticsContext and MappedDiagnosticsLogicalContext)

• the class name and renderer name for the layout renderer: NdlcLayoutRender ``${NDLC} (consistent with NdcLayoutRenderer/${NDC}, MDC, MDLC etc)

[snakefoot]

I propose:

@304NotModified Accepted

[304NotModified]

thanks!

[304NotModified]

@snakefoot

see it now in the code. It this really a Pop (should remove it from the stack)? looks like a Top method

[snakefoot]

Sorry not sure I understand the Pop-method modifies the stack by removing the top-element and returns it.

[304NotModified]

@snakefoot could you please help me by adding some docs to the wiki? Thanks!

[snakefoot]

@304NotModified Added new wiki page: https://github.com/NLog/NLog/wiki/NDLC-Layout-Renderer

[304NotModified]

thanks!!

[furier]

Could the documentation possibly be included to explain what is the purpose of NDLC and NDC and maybe how it differs from MDLC and MDC? With NLog 4.5 structured logging MDLC seems to add metadata properties that are part of the structured data being logged but not part of the message rendered, correct? What does NDLC do then? append the pushed value to the rendered message or prepended, does it also support structured data, etc...?

[304NotModified]

@furier please create a new github issue. Closed issues are difficult to track. Thanks!