Fix : LogManager.ReconfigureExistingLoggers() could throw InvalidOperationException

[jpdillingham]

…tently throws InvalidOperationException on Travis/Mono.

fixes #2130

[codecov]

Codecov Report

Merging #2131 into master will decrease coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2131    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         291     291            
  Lines       20103   20104     +1     
  Branches     2384    2384            
=======================================
- Hits        16342   16329    -13     
- Misses       3150    3163    +13     
- Partials      611     612     +1

[snakefoot]

Alternative one could change this method:

        public void ReconfigExistingLoggers()
        {
            List<Logger> loggers;
            lock (this.syncRoot)
            {
                if (this.config != null)
                {
                    this.config.InitializeAll();
                }

                //new list to avoid "Collection was modified; enumeration operation may not execute"
                loggers = new List<Logger>(loggerCache.Loggers);
            }

            foreach (var logger in loggers)
            {
                logger.SetConfiguration(this.GetConfigurationForLogger(logger.Name, this.config));
            }
        }

[304NotModified]

Thanks!

@snakefoot I think this is also OK. Thanks for the suggestion.

[snakefoot]

Then one might consider changing:

List<WeakReference> loggerReferences = new List<WeakReference>(loggerCache.Values.ToList());

Into:

List<WeakReference> loggerReferences = loggerCache.Values.ToList();

And if being super picky, then one could perform reverse-iteration, and use RemoveAt for WeakReference no longer active.

[304NotModified]

@snakefoot PR would be nice;)