Optional ConditionMethod arguments, ignoreCase argument for standard condition methods, EventLogTarget enhancements #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters can be omitted from the end of the parameter list (only).
…, retaining original behaviour as the default. Added new strequals function for string comparison with optional ignoreCase argument.
|
The current unit tests will fail if the copyright isn't the same as in all the other files. Also this would ensure we don't need permission from you to redistribute the changes. If it is possible please change to copyright to match the current files. |
|
Done as per your request. |
ghost
pushed a commit
that referenced
this pull request
May 16, 2013
Optional ConditionMethod arguments, ignoreCase argument for standard condition methods, EventLogTarget enhancements
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/* These changes were posted as part of a pull request against jkowalski/NLog a long time ago (Oct 2011) , but there seems to be a graveyard of pull requests there and NLog/NLog is active. There have been no subsequent changes to the files I touched back then. Below is part of my original pull request message (there were some EventLogTarget changes too, which I've left out as we now put them in our own custom extension assembly). */
Hi,
I noted that the ability to specify case sensitivity was present in the deprecated "whenEquals" (etc) conditions, but not in the newer "when" condition. So I've added support for optional (defaulted) arguments for ConditionMethod methods, and given the standard string-related ones an optional ignoreCase argument.
As a general note, I couldn't find any "how to contribute" documentation, so I'm not sure how you handle contributions, notably regarding copyright. For now, I've added copyright entries in the files I've touched/created with my employer's details, but I'm open to discussion on this.
I've built the code via build.cmd for netfx40, netfx35, netfx20 and sl3 (that's all the SDKs I've got installed) and addressed any code analysis issues. I've tested under netfx40 (including my silverlight-only code).
Regards,
Tom