JsonLayout - Don't mark ThreadAgnostic when IncludeMdc or IncludeMdlc is enabled

[snakefoot]

Different solution to the same problem.

[304NotModified]

I prefer to make it protected set. What do you think?

[snakefoot]

Well internal is "almost" private so it is more restrictive than protected. You are not allowed to upgrade the setter to protected, so it can be accessed by external classes.

Else the entire property should become protected, and part of the official interface. I don't think this internal optimization detail, should be exposed.

[304NotModified]

I meant protected internal. Not sure if that could be set on the setter only.

Its indeed and internal optimization (just makes the intention more clear).

[304NotModified]

Scratch that, its then protected or internal. Not and

[304NotModified]

I really prefer this solution :)

(reported here: #2109 (comment))

[304NotModified]

If you rebase on the latest master, does sonarqube work then?

[snakefoot]

If you rebase on the latest master, does sonarqube work then?

Not that strong with GIT. Can only see one master-branch, and no changes has been made to this for some time, and this PR is branched of that same master. What do you mean?

[304NotModified]

Could you do

git remote -v

[snakefoot]

git remote -v

andre   https://github.com/AndreGleichner/NLog.git (fetch)
andre   https://github.com/AndreGleichner/NLog.git (push)
nlog    https://github.com/NLog/NLog/ (fetch)
nlog    https://github.com/NLog/NLog/ (push)
origin  https://github.com/snakefoot/NLog.git (fetch)
origin  https://github.com/snakefoot/NLog.git (push)

[304NotModified]

Just on mobile, so hopefully no errors

git fetch --all
git rebase nlog/master

After fixing stuff (git rebase --continue)

When done

git push --force-with-lease

[304NotModified]

Updated it, you need fetch all

[snakefoot]

@304NotModified Updated and triggered rebuild

[codecov]

Codecov Report

Merging #2164 into master will increase coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2164    +/-   ##
=======================================
+ Coverage      81%     81%   +<1%     
=======================================
  Files         291     291            
  Lines       20124   20135    +11     
  Branches     2392    2394     +2     
=======================================
+ Hits        16343   16367    +24     
  Misses       3152    3152            
+ Partials      629     616    -13