${guid}, added GeneratedFromLogEvent #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 304 304
Lines 21380 21399 +19
Branches 2577 2578 +1
=======================================
+ Hits 17470 17489 +19
Misses 3256 3256
Partials 654 654 |
| byte i = (byte)(LogEventInfo.ZeroDate.Ticks >> 16); | ||
| byte j = (byte)(LogEventInfo.ZeroDate.Ticks >> 8); | ||
| byte k = (byte)(LogEventInfo.ZeroDate.Ticks); | ||
| builder.Append(new Guid(logEvent.SequenceID, (short)logEvent.TimeStamp.Month, (short)logEvent.TimeStamp.Year, d, e, f, g, h, i, j, k).ToString(this.Format)); |
There was a problem hiding this comment.
Clever approach!
But is this really a guid? (Global, unique)
There was a problem hiding this comment.
It is global unique identifier of a LogEvent within the running application. But probably not global in the universe.
snakefoot
force-pushed
the
GuidLayoutRendererLogEvent
branch
2 times, most recently
from
93b600e
to
6c32da1
Compare
| /// Generate the Guid from the NLog LogEvent (Will be the same for all targets) | ||
| /// </summary> | ||
| [DefaultValue(false)] | ||
| public bool LogEventGuid { get; set; } |
There was a problem hiding this comment.
What about "basedOnLogEvent"? Or "GeneratedFromLogEvent"
There was a problem hiding this comment.
@snakefoot ? Your opinion please :)
There was a problem hiding this comment.
Changed to GeneratedFromLogEvent
snakefoot
force-pushed
the
GuidLayoutRendererLogEvent
branch
from
6c32da1
to
f74bff5
Compare
304NotModified
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogEvent will output the same Guid for all Targets. Resolves #60 (And maybe #107)