EventPropertiesLayoutRenderer - Support Json Format #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
EventPropertiesJsonFormat
branch
from
2cbeb75
to
0caf167
Compare
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 304 304
Lines 21126 21132 +6
Branches 2531 2532 +1
=======================================
+ Hits 17275 17279 +4
- Misses 3216 3217 +1
- Partials 635 636 +1 |
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 304 304
Lines 21126 21127 +1
Branches 2531 2531
=======================================
+ Hits 17275 17277 +2
+ Misses 3216 3212 -4
- Partials 635 638 +3 |
snakefoot
force-pushed
the
EventPropertiesJsonFormat
branch
2 times, most recently
from
f2d8fe1
to
281aa7b
Compare
snakefoot
force-pushed
the
EventPropertiesJsonFormat
branch
from
281aa7b
to
1c90ae2
Compare
|
Updated the docs, feel free to change. |
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 304 304
Lines 21126 21312 +186
Branches 2531 2570 +39
=======================================
+ Hits 17275 17393 +118
- Misses 3216 3263 +47
- Partials 635 656 +21 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess it makes most sense when combined with #2208 (Or #2244)