NLog - NETSTANDARD1_5

[snakefoot]

Just checking if it can make a proper build

[codecov]

Codecov Report

Merging #2341 into master will increase coverage by <1%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #2341    +/-   ##
=======================================
+ Coverage      82%     82%   +<1%     
=======================================
  Files         317     318     +1     
  Lines       22720   22771    +51     
  Branches     2782    2782            
=======================================
+ Hits        18620   18666    +46     
- Misses       3396    3402     +6     
+ Partials      704     703     -1

[304NotModified]

looks good! (only checked the build result ;))

[304NotModified]

Think we should merge it after resolving the conflict?

I'm doubting about the unit tests. (enabling for netstandard1.5)

[snakefoot]

I'm doubting about the unit tests. (enabling for netstandard1.5)

Allmost all tests are working after removing all those for features not available (ex. NLogTraceListener). Except the tests that checks current-class-logger for inner-classes where NetStandard1_5 uses "." as last delimiter (instead of "+")

But it will require some effort to force the NetCoreApp2 to load the NetStandard1_5-dll.

[304NotModified]

But it will require some effort to force the NetCoreApp2 to load the NetStandard1_5-dll.

run it as NetCoreApp1?

[304NotModified]

AFAIK this works: https://github.com/NLog/NLog.Web/blob/b5335fe1ad4f0df97e2af1fd761c5cdb2dfe1b76/NLog.Web.AspNetCore.Tests/NLog.Web.AspNetCore.Tests.csproj#L3

[snakefoot]

run it as NetCoreApp1?

Well then I have to fix the UnitTest-project to work under NetStandard1_5

[snakefoot]

@304NotModified after resolving the conflict?

Conflicts resolved.

[304NotModified]

should the unit tests run in .net standard 1.5, as you have changed the testbase?

[snakefoot]

should the unit tests run in .net standard 1.5, as you have changed the testbase?

I have just made some changes, so it was easier to make local hack of adding NETSTANDARD1_5 to unit-test-project for NetCoreApp2 and removing NetStandard2.0 from Nlog.dll

Not in any condition to perform the NetStandard1.5 testing in current state on the build-server. Would also have to fix the 10 tests that detects behavior change in StrackTrace-logic.

[304NotModified]

OK thanks! Maybe later. I think we could run the tests on Travis in the future

[snakefoot]

@304NotModified Guess you could create an issue about the missing testing of the NetStandard1.5 assembly (Like #1186 and #1184)