Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLog - NETSTANDARD1_5 (revert breaking change) #2354

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 13, 2017

AppDomainWrapper is public (See also #1691)

@codecov
Copy link

codecov bot commented Oct 14, 2017

Codecov Report

Merging #2354 into master will decrease coverage by <1%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #2354    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         318     318            
  Lines       22770   22771     +1     
  Branches     2782    2782            
=======================================
- Hits        18678   18665    -13     
- Misses       3391    3403    +12     
- Partials      701     703     +2

@304NotModified
Copy link
Member

Do you mean: #1691 should be closed?

@snakefoot
Copy link
Contributor Author

Do you mean: #1691 should be closed?

Nope. #1691 is a good, but breaking change. Just wanted to repeat that I look forward to it being applied.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 14, 2017
@304NotModified 304NotModified added this to the 4.5 beta 7 milestone Oct 14, 2017
@304NotModified 304NotModified merged commit f4c1892 into NLog:master Oct 14, 2017
@snakefoot snakefoot modified the milestones: 4.5 beta 7, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants