Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLog - NETSTANDARD1_5 (Cleanup package references) #2362

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 15, 2017

Removed the System.Runtime.InteropServices.RuntimeInformation by using the implicit NetStandard.Library 1.6.0

Apparently one should not reference System.Runtime.InteropServices.RuntimeInformation directly

@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #2362 into master will decrease coverage by <1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2362    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         318     318            
  Lines       22791   22791            
  Branches     2783    2783            
=======================================
- Hits        18690   18670    -20     
- Misses       3399    3402     +3     
- Partials      702     719    +17

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 16, 2017
@304NotModified 304NotModified added this to the 4.5 beta 8 milestone Oct 16, 2017
@304NotModified
Copy link
Member

looks good!

@304NotModified 304NotModified merged commit a4ec69b into NLog:master Oct 16, 2017
@snakefoot snakefoot deleted the NetStandard15 branch December 4, 2017 19:50
@snakefoot snakefoot modified the milestones: 4.5 beta 8, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants