Target - Precalculate Layout should ignore sub-layouts for complex layouts #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…youts like JsonLayout
snakefoot
force-pushed
the
PrecalculateTopLayoutOnly
branch
from
89b1b98
to
591fe85
Compare
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 318 318
Lines 22796 22818 +22
Branches 2789 2793 +4
=======================================
- Hits 18671 18647 -24
- Misses 3419 3448 +29
- Partials 706 723 +17 |
snakefoot
force-pushed
the
PrecalculateTopLayoutOnly
branch
2 times, most recently
from
19383fb
to
ce04706
Compare
snakefoot
force-pushed
the
PrecalculateTopLayoutOnly
branch
from
ce04706
to
99c6ca5
Compare
snakefoot
force-pushed
the
PrecalculateTopLayoutOnly
branch
from
99c6ca5
to
f2f096c
Compare
…youts like JsonLayout (More scan details)
snakefoot
force-pushed
the
PrecalculateTopLayoutOnly
branch
from
f2f096c
to
c93f6fb
Compare
304NotModified
approved these changes
Nov 7, 2017
|
merged, thx! |
Closed
This was referenced Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance optimization for async-target, so it will not render and string-allocate for each individual sub-layout.
This will improve performance for complex layouts like the JsonLayout (Has a sub-layout for each json-attribute, but they don't need to be rendered individually, only the top JsonLayout).