Fixed Sonar Lint code analysis warnings #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
SonarLintCodeAnalysis
branch
2 times, most recently
from
125b383
to
bff9fbd
Compare
…r.TryImplicitConversion
snakefoot
force-pushed
the
SonarLintCodeAnalysis
branch
from
bff9fbd
to
f464e90
Compare
snakefoot
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 318 318
Lines 22796 22805 +9
Branches 2789 2790 +1
=======================================
- Hits 18671 18665 -6
- Misses 3419 3433 +14
- Partials 706 707 +1 |
| private Stack<object> _stack; | ||
| private int _previousCount; | ||
| private readonly Stack<object> _stack; | ||
| private readonly int _previousCount; |
There was a problem hiding this comment.
note that readonly could influence runtime performance (badly)
There was a problem hiding this comment.
Only heard that it affect performance for fields in struct, where it will cause the entire struct to be copied on field access. Do you have some details about this other readonly pitfall?
There was a problem hiding this comment.
this one, but that's indeed structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And cleaned up PropertyHelper.TryImplicitConversion (Turned ugly with NetStandard1.5)